WIP monitor gradle projects with kotlin build scripts#129
WIP monitor gradle projects with kotlin build scripts#129lmmarsano wants to merge 2 commits intoemacs-lsp:masterfrom
Conversation
add tests for gradle DSLs - groovy - kotlin import fails for gradle kotlin DSL
convert `project-types` local variable to a custom variable for extendability include build.gradle.kts to detect all gradle projects update glob patterns to watch these files
lmmarsano
force-pushed
the
fix/gradle-kotlin-dsl
branch
from
4d8cd0c to
44b77e7
Compare
|
I guess this change is fixing your issue because you are not adding the proper project roots. Normally this method should not be used and it is leftover from the time jdt-ls was supporting only one root. You may verify that by doing lsp-describe-session - one of the roots should be the folder containing your build file. |
|
Thanks. |
|
We might still want to monitor the build file for changes, e. g. when you edit pom.xml file it notifies the server and the server refreshes the workspace. |
|
Sure. Anything I should change or add? |
| (vector (ht ("globPattern" "**/*.java")) | ||
| (ht ("globPattern" "**/pom.xml")) | ||
| (ht ("globPattern" "**/*.gradle")) | ||
| (ht ("globPattern" "**/*.gradle{,.kts}")) |
There was a problem hiding this comment.
It is more about the testing - you may keep this line(although I am not sure whether this pattern works) and then modify the kts file(e. g. add new dependency) and then:
- Verify that lsp-java is sending update to the server
- Verify that jdt-ls is updating the workspace(you will start to receive notifications).
If 2) is not happening we have to file jdtls bug.
There was a problem hiding this comment.
Nothing happens with the line as written.
Should we consider this a bug?
As separate lines, however, client works, and server fails to update:
*lsp-log*showsworkspace/didChangeWatchedFilesnotifications~/.emacs.d/workspace/.metadata/.logshows!MESSAGE >> workspace/didChangeWatchedFilesbut no message like!MESSAGE Updated java-test in 382 msthat shows with modification to groovy build files.
When commenting out a dependency, imports continue to show as resolved in kotlin build file projects, though groovy build file projects get 'import cannot be resolved' updates.
There was a problem hiding this comment.
IMO it is a bug. Can you check whether the change is applied if you restart the jdt ls server? If it works, that means the problem is in jdt-ls which does not process the file notification.
There was a problem hiding this comment.
No change: commented out dependency still resolves after lsp-restart-workspace.
eclipse-jdtls/eclipse.jdt.ls#449 seems to indicate Kotlin build file support is missing.
lmmarsano
changed the title
|
eclipse-jdtls/eclipse.jdt.ls#449 seems relevant |
2 participants
lsp-javawasn't importing gradle projects initialized to use kotlin build scripts.As a result,
lspwas indicating valid code as wrong, and it wasn't locating the project root/workspace.This pull request fixes those issues for me.
I also exposed the list of possible project configuration files as a custom variable, since it might save users inconvenience when trying out new/experimental build tools.
Despite adding tests to cover these cases, however, the project's tests don't seem work at all, even on the continuous integration platform.
I'd recommend someone who's ever gotten
ecukesto work (never has for me), to fix the tests.Does this need further work?